-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ishan Agarwal] iP #765
Open
ishan-agarwal-05
wants to merge
83
commits into
nus-cs2103-AY2425S1:master
Choose a base branch
from
ishan-agarwal-05:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Ishan Agarwal] iP #765
ishan-agarwal-05
wants to merge
83
commits into
nus-cs2103-AY2425S1:master
from
ishan-agarwal-05:master
+3,287
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Add Save tasks and Load tasks
Add time and date parsing, along with on command. Add help command
…5/ip into branch-A-MoreOOP
Branch a more oop
* add-gradle-support: build.gradle: Prevent generating a second JAR file Bump gradle and lib version Add Gradle support
…5/ip into branch-A-CodeQuality * 'branch-A-Streams' of https://github.com/ishan-agarwal-05/ip:
…al-05/ip into branch-A-Streams * 'branch-A-CodeQuality' of https://github.com/ishan-agarwal-05/ip:
* branch-A-Streams:
* 'master' of https://github.com/ishan-agarwal-05/ip: Update README.md
…5/ip into branch-A-CodeQuality * 'branch-A-Streams' of https://github.com/ishan-agarwal-05/ip: Update Readme and add acknowledgment Update README.md fix link in readme Update README.md clean up code remove bug in deadline and event date format
…al-05/ip into branch-A-Streams * 'branch-A-CodeQuality' of https://github.com/ishan-agarwal-05/ip:
…5/ip into branch-A-CodeQuality * 'branch-A-Streams' of https://github.com/ishan-agarwal-05/ip:
* branch-A-CodeQuality:
…5/ip into branch-A-CodeQuality * 'branch-A-Streams' of https://github.com/ishan-agarwal-05/ip: no message
* branch-A-CodeQuality: no message # Conflicts: # src/main/java/johncena/parser/InputHandler.java
* 'master' of https://github.com/ishan-agarwal-05/ip: Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New Features to JohnCena List Application 🎉
This pull request introduces several enhancements to the Todo List application, including new commands and functionalities.
Summary of Changes
todo
deadline
event
find
New Features
Todo Command
todo <description>
Deadline Command
deadline <description> /by <date>
Event Command
event <description> /from <start date> /to <end date>
Find Command
find <keyword>
Example Code