Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2103T-T08-4] GoonBook #136

Open
wants to merge 387 commits into
base: master
Choose a base branch
from
Open

[CS2103T-T08-4] GoonBook #136

wants to merge 387 commits into from

Conversation

Hoodini231
Copy link

Our product targets school teachers and tutors to better organise and handle student information such as names, class groupings, grades, parent information and other important information

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.03167% with 75 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/GroupListPanel.java 0.00% 13 Missing ⚠️
...va/seedu/address/logic/commands/ImportCommand.java 86.76% 6 Missing and 3 partials ⚠️
src/main/java/seedu/address/ui/GroupCard.java 0.00% 8 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 25.00% 6 Missing ⚠️
...n/java/seedu/address/storage/JsonAdaptedGroup.java 68.42% 6 Missing ⚠️
...u/address/storage/JsonSerializableAddressBook.java 45.45% 5 Missing and 1 partial ⚠️
...eedu/address/logic/parser/ImportCommandParser.java 69.23% 2 Missing and 2 partials ⚠️
src/main/java/seedu/address/model/group/Group.java 55.55% 2 Missing and 2 partials ⚠️
...seedu/address/logic/commands/FindGroupCommand.java 85.00% 1 Missing and 2 partials ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 3 Missing ⚠️
... and 9 more
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/Main.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/logic/Messages.java 90.00% <100.00%> (+2.50%) 7.00 <4.00> (+4.00)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 100.00% <ø> (ø) 13.00 <0.00> (ø)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...edu/address/logic/commands/DeleteGroupCommand.java 100.00% <100.00%> (ø) 7.00 <0.00> (?)
...java/seedu/address/logic/commands/EditCommand.java 97.26% <100.00%> (-0.18%) 13.00 <0.00> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...ava/seedu/address/logic/commands/GroupCommand.java 100.00% <100.00%> (ø) 18.00 <12.00> (?)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <100.00%> (ø) 3.00 <0.00> (+1.00)
... and 46 more

... and 3 files with indirect coverage changes

Hoodini231
Hoodini231 commented Oct 2, 2024
View reviewed changes
Copy link
Author

@Hoodini231 Hoodini231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong. fix file name now.

martout2002 and others added 28 commits October 24, 2024 17:18
@martout2002
Add Find Command activity diagram
21ee7c7
@Hoodini231
Add uml for export
aeb5643
@Hoodini231
Fix EOL issue on ExportSequenceDiagram.puml
32d2979
@wenjebs
Merge pull request #91 from Hoodini231/branch-import
c193cb4 
Add import command and fixed bugs as well as tests
@wenjebs
Merge pull request #95 from wenjebs/update-colors
93b7297 
Update colors
@wenjebs
Merge pull request #96 from martout2002/puml-for-person
5918f06 
Add Group to puml
@wenjebs
Merge pull request #97 from wenjebs/update-uml-wenjie
ad6394b 
Update uml wenjie
@wenjebs
Merge pull request #100 from Hoodini231/branch-export-uml
ea492ba 
Add PlantUML logic sequence for export
@martout2002
Allow Person to be added without tags
e5ad330
@martout2002
Fix checkstyle
0b69f73
@yimjianbing
Merge branch 'master' of https://github.com/yimjianbing/tp into Refac…
4c927bd 
…tor-UI
@hyxnnii
Revise UML class diagram
61bd2a6 
Previous UML class diagram is outdated as pre-existing features
have been changed and new features have been added.

Changes to such features are now reflected in
BetterModelClassDiagram now.
@yimjianbing
Merge pull request #103 from hyxnnii/add-uml-diagram
d538974 
Revise UML class diagram
@yimjianbing
Fix and add new test files for refactored commands
72e5e47
@yimjianbing
Fix checkstyle errors
aea04e8
@yimjianbing
Merge branch 'master' of https://github.com/yimjianbing/tp into Refac…
1baec28 
…tor-UI
@yimjianbing
Fix no newlines and EOF for checkstyles
b91f425
@yimjianbing
Update addressbook.json to have new line at EOF
ad8df19
@yimjianbing
Delete unused json file
fc1e1a7
@yimjianbing
Merge branch 'Refactor-UI' of https://github.com/yimjianbing/tp into …
3805654 
…Refactor-UI

# Conflicts:
#	addressbook.json
@yimjianbing
remove addressbook.json
fa230d1
@yimjianbing
Fix checkstyle errors in src/main
abfff42
@yimjianbing
Add GroupListTest.java for code coverage
c348761
@yimjianbing
add addressbook.json to gitignore
ea44e15
@yimjianbing
Add more test files
a7663c7
@yimjianbing
Add more tests for better code coverage
474eb77
@yimjianbing
Remove one test
a7579a0
@yimjianbing
Add even more test liens to GroupContainsKeywordsPredicate
f52de1b
martout2002 and others added 5 commits November 11, 2024 21:41
@martout2002
Merge pull request #265 from martout2002/master
82e973a 
Check
@hyxnnii
Increase code coverage
461caeb 
PR does not pass code coverage.

Tests are added.
@hyxnnii
Increase code coverage
b9cd4c6 
PR does not pass code coverage.

Tests are added.
@martout2002
AddressBook change
1de5984
@martout2002
Update UG for 2101
cb41660
yimjianbing and others added 24 commits November 12, 2024 00:27
@yimjianbing
Add a GroupSequenceDiagram uml
b8667ce
@yimjianbing
Merge branch 'master' of https://github.com/yimjianbing/tp into Fix-DG
b7d07f5
@yimjianbing
Add new Sequence Diagrams, and revamp the planned implementation section
c01eeea
@yimjianbing
Add newline to EOF
559aa95
@yimjianbing
Merge pull request #276 from yimjianbing/Fix-DG
705f008 
Fix dg
@yimjianbing
Update TOC
af6a2b1
@yimjianbing
Merge pull request #277 from yimjianbing/Fix-DG
9183daf 
Update TOC
@yimjianbing
Fix broken TOC on DG
ab377a9
@yimjianbing
Add correct link for hyperlink in UG
bfefd35
@yimjianbing
Merge pull request #278 from yimjianbing/Fix-DG
95d279f 
Fix dg
@yimjianbing
Scale up DG diagram imagees to become clearer
b7333dc
@yimjianbing
Merge pull request #279 from yimjianbing/Fix-DG
dc0bc78 
Scale up DG diagram imagees to become clearer
@yimjianbing
fix formatting issue with DG TOC
50ca264
@yimjianbing
Merge pull request #280 from yimjianbing/Fix-DG
0196d5b 
fix formatting issue with DG TOC
@yimjianbing
Fix broken hyperlinks in TOC
d634d51
@yimjianbing
Merge pull request #281 from yimjianbing/Fix-DG
5513999 
Fix broken hyperlinks in TOC
@hyxnnii
Clean up DG
a5ea797 
Some formattings are off and some information are not accurate.

Final clean up of DG is done.
@hyxnnii
Merge pull request #282 from hyxnnii/dg-update
366e082 
Clean up DG
@hyxnnii
Clean up DG
b877691 
Some formattings are off and some information are not accurate.

Final clean up of DG is done.
@hyxnnii
Merge pull request #283 from hyxnnii/dg-update
2091db6 
Clean up DG
@hyxnnii
Clean up DG
2320a79 
Some formattings are off and some information are not accurate.

Final clean up of DG is done.
@hyxnnii
Merge pull request #284 from hyxnnii/dg-update
1b19d12 
Clean up DG
@hyxnnii
Clean up UG
d178cce 
Some formattings are off and some information are not accurate.

Final clean up of DG is done.
@hyxnnii
Merge pull request #285 from hyxnnii/dg-update
8b3f9bf 
Clean up UG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hoodini231 @martout2002 @wenjebs @yimjianbing @hyxnnii