Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test pull request #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test pull request #72

wants to merge 1 commit into from

Conversation

tttyyzzz
Copy link

test pull request

tttyyzzz
tttyyzzz commented Sep 10, 2021
View reviewed changes
src/main/java/Contacts1.java
@@ -595,6 +595,7 @@ private static boolean isValidName(String name) {
private static boolean isValidPhone(String phone) {
return !phone.isEmpty();
//TODO: implement a better validation
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good try for 1st attempt

src/main/java/Contacts1.java
@@ -595,6 +595,7 @@ private static boolean isValidName(String name) {
private static boolean isValidPhone(String phone) {
return !phone.isEmpty();
//TODO: implement a better validation

}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good try for 2nd attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tttyyzzz