Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-resolution playback #46

Merged
merged 9 commits into from
Oct 26, 2023

Conversation

ngchisern
Copy link
Collaborator

This PR introduces support for multi-resolution playback:

  • Users can now supply either 1 or 3 arguments as their files/folders.

Implementation Details:

  • A new render reader, AdaptiveReader, has been introduced.
  • Depending on the camera state, the AdaptiveReader selects the appropriate reader for data retrieval.

Future Work:

  1. Currently, the reader selection is solely based on the model's distance from the camera. A better heuristic, such as point distance rendered on the screen, can be utilized.
  2. Allow users to input an arbitrary number of files (>= 1).
  3. Re-evaluate the camera state updating mechanism, as cloning operations can be costly.

@ngchisern ngchisern marked this pull request as draft October 24, 2023 04:18
@ngchisern ngchisern marked this pull request as ready for review October 26, 2023 06:35
@weitsang weitsang merged commit 947580f into nus-vv-streams:main Oct 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants