Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main_merge_vvdash, Implement Playback Cache and Refactor vvplay_async #47

Merged
merged 127 commits into from
Jan 5, 2024

Conversation

tiif
Copy link
Contributor

@tiif tiif commented Dec 27, 2023

  • Merged changes from main_merge_vvdash to have prefetching behaviour
  • Implemented playback cache to store frames that have already been rendered. This reduces the need for re-rendering and improves playback performance.
  • Refactored vvplay_async by separating its functionality into distinct part under vvplay_async_prefetch

Manually tested:

  • vv read basic
  • vvplay
  • vvplay_async
  • vv convert ply to pcd(binary)
  • vv info

This warning is not resolved for now:

warning: the following packages contain code that will be rejected by a future version of Rust: bindgen v0.54.0

Bindgen is a transitive dependency through tmc2rs, to resolve it, we might need to update the package version for tmc2rs.
image

  • Screenshot of cargo tree result

@tiif tiif mentioned this pull request Dec 30, 2023
@weitsang weitsang merged commit 4899a99 into nus-vv-streams:main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants