-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main_merge_vvdash, Implement Playback Cache and Refactor vvplay_async #47
Merged
weitsang
merged 127 commits into
nus-vv-streams:main
from
tiif:branch-vvplay_async-refactor
Jan 5, 2024
Merged
Merge main_merge_vvdash, Implement Playback Cache and Refactor vvplay_async #47
weitsang
merged 127 commits into
nus-vv-streams:main
from
tiif:branch-vvplay_async-refactor
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quetra ply play
It is unused for vvplay_async.rs.
Rewrite the function that involved CameraPosition due to incompatibility
Merged
weitsang
approved these changes
Jan 5, 2024
weitsang
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested:
This warning is not resolved for now:
Bindgen is a transitive dependency through tmc2rs, to resolve it, we might need to update the package version for tmc2rs.
cargo tree
result