Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port before_v0.60/with_externals and cleanup #852

Merged

Conversation

39555
Copy link
Contributor

@39555 39555 commented May 26, 2024

This PR is the final part 🎉 of porting all old scripts #221 and includes with_externals module and cleanup of different files

39555 added 3 commits May 26, 2024 22:26
- remove `js_map.json` because it has already been moved to `sourced/cool-oneliners/assets/`
- remove `lib/scripts.nu` because it only sources `language/std`
- remove orphaned README from std_candidate, because it already exists in nu_scripts/std_candidate
- remove top level README.md
- add `export`
- add `...` spread
- `pivot` -> `transpose`
@fdncred
Copy link
Collaborator

fdncred commented May 26, 2024

nice work. the json map was used in another script. i guess it's not used now?

@39555
Copy link
Contributor Author

39555 commented May 26, 2024

@fdncred Before:
before_v0.60/cool_oneliners/js_map_to_markdown.nu
line 2 open ../assets/js_map.json ...

Now:
sourced/cool-oneliners/js_map_to_markdown.nu
line 2 open assets/js_map.json ...

file js_map.json now in sourced/cool_oneliners/assets/js_map.json

@fdncred
Copy link
Collaborator

fdncred commented May 26, 2024

Ok. Thanks

@fdncred fdncred merged commit 42732da into nushell:main May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants