-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadnames and update contact info #1343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! All of the comments below just have to do with fixing table output formatting due to changes in the width of columns.
@@ -24,7 +24,7 @@ Nuevamente ejecutemos el comando `open` pero esta vez observaremos las etiquetas | |||
----------+------------------------------------------ | |||
span | anchor | |||
----------+------------------------------------------ | |||
[object] | /home/jonathan/Source/nushell/Cargo.toml | |||
[object] | /home/sophia/Source/nushell/Cargo.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
@IanManske - I think I got them now |
@sophiajt Thanks! Just one spot left, it's the unresolved |
@IanManske - oops, missed that one. Fixed. |
Sorry to whoever reviews this 😅
This updates my contact info and fixes deadnames -> Sophia wherever possible. There are some table shenanigans (sorry), which hopefully will clear up over time.