Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadnames and update contact info #1343

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

sophiajt
Copy link
Contributor

@sophiajt sophiajt commented Apr 8, 2024

Sorry to whoever reviews this 😅

This updates my contact info and fixes deadnames -> Sophia wherever possible. There are some table shenanigans (sorry), which hopefully will clear up over time.

Copy link
Member

@IanManske IanManske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All of the comments below just have to do with fixing table output formatting due to changes in the width of columns.

blog/2020-09-01-nushell_0_19.md Outdated Show resolved Hide resolved
book/shells_in_shells.md Show resolved Hide resolved
ja/book/shells_in_shells.md Show resolved Hide resolved
pt-BR/book/shells_em_shells.md Show resolved Hide resolved
zh-CN/book/shells_in_shells.md Outdated Show resolved Hide resolved
pt-BR/book/metadados.md Show resolved Hide resolved
es/book/shells_en_shells.md Show resolved Hide resolved
@@ -24,7 +24,7 @@ Nuevamente ejecutemos el comando `open` pero esta vez observaremos las etiquetas
----------+------------------------------------------
span | anchor
----------+------------------------------------------
[object] | /home/jonathan/Source/nushell/Cargo.toml
[object] | /home/sophia/Source/nushell/Cargo.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

blog/2020-08-23-year_of_nushell.md Show resolved Hide resolved
blog/2019-08-23-introducing-nushell.md Show resolved Hide resolved
@sophiajt
Copy link
Contributor Author

sophiajt commented Apr 9, 2024

@IanManske - I think I got them now

@IanManske
Copy link
Member

@sophiajt Thanks! Just one spot left, it's the unresolved es/book/metadatos.md above.

@sophiajt
Copy link
Contributor Author

sophiajt commented Apr 9, 2024

@IanManske - oops, missed that one. Fixed.

@IanManske IanManske merged commit 6b09198 into nushell:main Apr 9, 2024
2 checks passed
@sophiajt sophiajt deleted the deadname_fix branch April 9, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants