-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "return value" topics to "Thinking in Nu" #1677
Conversation
@kubouch If you get a chance, I'd love your review, but especially the revisions to "Parse-time Evaluation" since this is based on your work in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks! I left a few quick comments from my phone, but I didn't find anything that would desperately need fixing, you can address / not address them as you see fit.
@kubouch Thanks! I've just pushed some changes based on your feedback. Greatly appreciated! |
OK, looks good, it can always be refined in other PRs. We might want to start talking about Nushell as statically compiled instead of just compiled to avoid the confusion with Python bytecode, see my comment above. |
Another fairly substantial update to the "Thinking in Nu" chapter. It adds two major topics that often confuse new users:
Also:
Major update to "Think of Nushell as a Compiled Language" and the linked "How Nushell Code Gets Run" chapter
eval
was much more visible than the benefits. Hopefully the benefits are more clear now.Adds a Table-of-Contents to both chapters
Each section closes with a "Thinking in Nushell" callout for consistency. (Side-note: This is listed as a "warning" block, but only for color/style to make it most noticeable).
Additional rewrites for clarity and flow