Remove redundant setting insertion point to 0

nushell · Jun 21, 2021 · af487f9 · af487f9
1 parent 2025d88
commit af487f9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/engine.rs b/src/engine.rs
@@ -313,8 +313,6 @@ impl Reedline {
 
     fn clear(&mut self) {
         self.line_buffer.clear();
-        // Note: This should be redundant
-        self.set_insertion_point(0);
     }
 
     fn append_to_history(&mut self) {

diff --git a/src/line_buffer.rs b/src/line_buffer.rs
@@ -333,6 +333,15 @@ mod test {
         assert!(line_buffer.is_empty())
     }
 
+    #[test]
+    fn test_clearing_line_buffer_resets_buffer_and_insertion_point() {
+        let mut buffer = buffer_with("this is a command");
+        buffer.clear();
+        let empty_buffer = LineBuffer::new();
+
+        assert_eq!(buffer, empty_buffer)
+    }
+
     #[test]
     fn insert_str_updates_insertion_point_point_correctly() {
         let mut line_buffer = LineBuffer::new();