add explicit panic to stay backwards compatible

nushell · Jan 27, 2024 · d6ab845 · d6ab845
1 parent 0493c0d
commit d6ab845
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/menu/mod.rs b/src/menu/mod.rs
@@ -66,7 +66,12 @@ pub enum MenuEvent {
 /// Trait that defines how a menu will be printed by the painter
 pub trait Menu: Send {
     /// Get MenuSettings
-    fn settings(&self) -> &MenuSettings;
+    fn settings(&self) -> &MenuSettings {
+        // We panic here, so this function has base implementation
+        // so existing menus will not break.
+        // if a breaking change is ok, this can be removed 
+        panic!("`settings` requires a manual implementation per menu. It has a base implementation to not break existing menus")
+    }
 
     /// Menu name
     fn name(&self) -> &str {