Revert crossterm: key modifier issue on win #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossterm 0.23 seems to have introduce a regression on windows for decoding keybindings with `ctrl` that uppercases the char. Tracking issue crossterm-rs/crossterm#636 Might be fixed by crossterm-rs/crossterm#629
sholderbach
force-pushed
the
revert-crossterm
branch
from
427841c to
ce1415c
Compare
|
@elferherrera can you give it a try if this resolves the ctrl-uppercase issue for you? |
|
I wonder if this needs to be done in nushell too since it's v23? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossterm 0.23 seems to have introduced a regression on windows for
decoding keybindings with
ctrlthat uppercases the char.Tracking issue crossterm-rs/crossterm#636
Might be fixed by crossterm-rs/crossterm#629