-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make history-related items (de-)serializable #678
Conversation
I generally don't have problems with your recent PRs but I'd like to see something in the description that we can refer to later, even though these are quite simple changes. Obviously the CI needs to be green too. :) Where are you integrating reedline that is forcing you to make these changes? I'm just interested to see what you're doing. |
Just edited the description and updated the code so the CI should pass.
I'm building full-blown custom shell, and I'm currently polishing the last parts, like the history. I want to store specific informations, maybe perform history synchronization between shell instances etc. So I absolutely need a custom |
thanks for the info. i landed your pr that had a green ci. |
CI is now green. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
=======================================
Coverage 49.16% 49.16%
=======================================
Files 46 46
Lines 7926 7926
=======================================
Hits 3897 3897
Misses 4029 4029
|
one of the other prs caused a conflict here |
Fixed. |
good luck, have fun! |
Is this public somewhere that i can look and play with it? |
Sure: https://github.com/ClementNerma/ReShell Please note that there is no tutorial or documentation yet, so you'll have to decode the Here is a little example (note that they are still some bugs, especially on the stack): fn fibonacci(value: int) -> int {
return if $value < 1 {
0
} else if $value <= 2 {
1
} else {
fibonacci($value - 1) + fibonacci($value - 2)
}
}
for i in range(1, 100) {
echo "fib $i = ${fibonacci($i)}"
} |
This PR makes history-related items like
HistoryItem
andHistoryItemId
(among others) serializable and deserializable throughserde
. This allows building customHistory
more easily.