Move left when exiting insert mode #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandruradovici
suggested changes
Jan 23, 2024
|
Does the second checkbox mean this PR is not finished? |
|
Updated, will stay as it is |
|
@stormasm I don't use vi mode. Any thoughts on this change? |
|
@andreistan26 can you please make sure the code you are changing still works fine with all of the latest changes that we have landed in Reedline recently ? In other words merge your code back into the latest main so we can have the CI run again. And test your code to make sure it works as you think it should.... Thank you ! |
andreistan26
force-pushed
the
vi-mode
branch
2 times, most recently
from
ffb1e89 to
edb2614
Compare
Signed-off-by: Andrei Stan <[email protected]>
|
Rebased and tested with latest |
|
@andreistan26 Thank you for checking the code one more time prior to us landing... |
sholderbach
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #694 using the
vieditor mode does not match the behavior of thevim/viCLI editors.