-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add style from #691 to ide menu #722
Conversation
This reverts commit 070d600.
What does this look like now with a style? |
This reverts commit 62726f2.
Thanks. That looks cool!! |
@maxomatic458 just curious to know why when you do PRs do you work off your main branch ? I think it would be easier if you created a branch first and then started working on the PR... This way if one of your PRs doesn't land right away you can update your main to the latest version of Reedline (for example) and then start another PR by branching off main.... The reason I mention this is because of your revert above when you started working on menu refactor and then had to revert because you were on the main branch where this PR is located... |
@stormasm And i forgot that i was still on main when starting to work on refactoring the menus. I should probably start doing that. |
@maxomatic458 can you please post the style setting along with the config.nu stuff surrounding it so I can test it with my nushell config.nu Thanks ! |
@stormasm i think this only works with external completers (so nothing needs to be changed in nushells config) i used https://carapace.sh |
No description provided.