Add a way to disable the prompt #729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtpg can you please add in a example that shows this working... Thanks ! |
|
@rtpg as far as the example it can be as simple as the https://github.com/nushell/reedline/blob/main/examples/basic.rs but call it disable_prompt.rs |
I don't really understand what you're saying here. Can you add an example and some test to ensure this behavior works in the future? |
fdncred
reviewed
Feb 9, 2024
| @@ -487,6 +487,12 @@ impl Reedline { | |||
| self.transient_prompt = Some(transient_prompt); | |||
| self | |||
| } | |||
| /// Remove the current prompt | |||
There was a problem hiding this comment.
Should this be
Suggested change
| /// Remove the current prompt | |
| /// Remove the current transient prompt |
|
unresponsive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of work to simplify this nushell PR. Clearing out the prompt removes a reference to the stack, letting us avoid a copy