Static analysis coverity fixes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes includes: 1. Explicit initialise variables before use. 2. NULL checks for pointers before use. 3. Missing deallocations. 4. Changed time(NULL) to timespec to avoid int overflow. 5. Fixed few printfs/LOG. Signed-off-by: Priyankar Jain <[email protected]>
1. Fix for TOCTOU: Use mkdir directly and check for errno instead of using stat and then mkdir. 2. Added explicit break statements in switch case. 3. int to enum explicit type casting. Signed-off-by: Priyankar Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes includes:
using stat and then mkdir.