Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/libvfio-user: Fix calloc-transposed-args reported by gcc >= 14 #802

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mikeBashStuff
Copy link
Contributor

@mikeBashStuff mikeBashStuff commented Aug 16, 2024

Fixes #801.

Signed-off-by: Michal Berger [email protected]

@jlevon
Copy link
Collaborator

jlevon commented Aug 16, 2024

ugh, they broke centos-7, hold on :/

@jlevon jlevon merged commit a5fca05 into nutanix:master Aug 16, 2024
7 checks passed
jlevon pushed a commit that referenced this pull request Aug 16, 2024
)

Fixes issue #801.

Signed-off-by: Michal Berger <[email protected]>
(cherry picked from commit a5fca05)
@jlevon
Copy link
Collaborator

jlevon commented Aug 16, 2024

Thanks for the fix @mikeBashStuff
I have cherry-picked it to the branch spdk used for, well, SPDK. Would you like me to raise a gerrit there, or are you planning to do that?

@mikeBashStuff
Copy link
Contributor Author

@jlevon I haven't looked into adjusting submodule on the SPDK's end yet, pushed this instead: https://review.spdk.io/gerrit/c/spdk/spdk/+/24558.

But if this pr is already merged I guess we could go with updating the submodule and dropping the above patch. So https://review.spdk.io/gerrit/c/spdk/spdk/+/24583.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc >= 14 hits calloc-transposed-args
2 participants