Skip to content

Avoid rewriting cache without changes #182

Avoid rewriting cache without changes

Avoid rewriting cache without changes #182

Triggered via push December 1, 2024 08:12
Status Success
Total duration 50s
Artifacts

test.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 4 warnings
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 15 | | sameSite -> Integer, | | -------- `sameSite` is not local 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_samesite` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 14 | | inBrowserElement -> Integer, | | ---------------- `inBrowserElement` is not local 15 | | sameSite -> Integer, 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_inbrowserelement` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 13 | | isHttpOnly -> Integer, | | ---------- `isHttpOnly` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_ishttponly` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 12 | | isSecure -> Integer, | | -------- `isSecure` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_issecure` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 11 | | creationTime -> Integer, | | ------------ `creationTime` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_creationtime` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 10 | | lastAccessed -> Integer, | | ------------ `lastAccessed` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_lastaccessed` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 9 | | expiry -> Integer, | | ------ `expiry` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_expiry` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 8 | | path -> Text, | | ---- `path` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_path` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 7 | | host -> Text, | | ---- `host` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_host` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, 5 | | name -> Text, 6 | | value -> Text, | | ----- `value` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_value` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, 5 | | name -> Text, | | ---- `name` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_name` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, | | ---------------- `originAttributes` is not local ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_originattributes` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L15
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, | | -- `id` is not local 4 | | originAttributes -> Text, ... | 16 | | } 17 | | } | | ^ | | | | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_id` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/diesel-1.4.8/src/macros/mod.rs#L642
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_schema.rs:1:1 | 1 | / table! { 2 | | moz_cookies (id) { 3 | | id -> Integer, 4 | | originAttributes -> Text, ... | 16 | | } 17 | | } | | ^ | | | | | `table` is not local | |_`QueryId` is not local | move the `impl` block outside of this function `_impl_query_id_for_table` | = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: this error originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info)
non-local `impl` definition, `impl` blocks should be written at the same level as their item: src/cookie/db_models.rs#L19
error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> src/cookie/db_models.rs:19:10 | 19 | #[derive(Queryable, Debug)] | ^-------- | | | `Queryable` is not local | move the `impl` block outside of this function `_impl_queryable_for_firefoxcookie` 20 | pub struct FirefoxCookie { | ------------- `FirefoxCookie` is not local | = note: the derive macro `Queryable` defines the non-local `impl`, and may need to be changed = note: the derive macro `Queryable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` = note: `-D non-local-definitions` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(non_local_definitions)]` = note: this error originates in the derive macro `Queryable` (in Nightly builds, run with -Z macro-backtrace for more info)
`flatten()` will run forever if the iterator repeatedly produces an `Err`: src/lib.rs#L181
error: `flatten()` will run forever if the iterator repeatedly produces an `Err` --> src/lib.rs:181:18 | 181 | .flatten() | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` | note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error --> src/lib.rs:180:24 | 180 | let data = stdin.lock().lines() | ^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok = note: `-D clippy::lines-filter-map-ok` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::lines_filter_map_ok)]`
unnecessary use of `get(&self.level).is_none()`: src/lib.rs#L160
error: unnecessary use of `get(&self.level).is_none()` --> src/lib.rs:160:23 | 160 | if self.brief.get(&self.level).is_none() || force { | -----------^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!self.brief.contains_key(&self.level)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `-D clippy::unnecessary-get-then-check` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_get_then_check)]`
empty line after outer attribute: src/lib.rs#L59
error: empty line after outer attribute --> src/lib.rs:59:5 | 59 | / #[serde(serialize_with = "ordered_map")] 60 | | | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr = note: `-D clippy::empty-line-after-outer-attr` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::empty_line_after_outer_attr)]` = help: if the empty line is unintentional remove it
use of `format!` to build up a string from an iterator: src/http.rs#L50
error: use of `format!` to build up a string from an iterator --> src/http.rs:50:17 | 50 | let brief = brief.lines() | _________________^ 51 | | .skip(2) 52 | | .take(num_lines - 4) 53 | | .map(|l| format!("{}\n", l)) 54 | | .collect::<String>() | |____________________________^ | help: call `fold` instead --> src/http.rs:53:10 | 53 | .map(|l| format!("{}\n", l)) | ^^^ help: ... and use the `write!` macro here --> src/http.rs:53:18 | 53 | .map(|l| format!("{}\n", l)) | ^^^^^^^^^^^^^^^^^^ = note: this can be written more efficiently by appending to a `String` directly = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect = note: `-D clippy::format-collect` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::format_collect)]`
multiple fields are never read: src/cookie/db_models.rs#L21
error: multiple fields are never read --> src/cookie/db_models.rs:21:9 | 20 | pub struct FirefoxCookie { | ------------- fields in this struct 21 | pub id: i32, | ^^ 22 | pub originAttributes: String, | ^^^^^^^^^^^^^^^^ 23 | pub name: String, | ^^^^ 24 | pub value: String, 25 | pub host: String, | ^^^^ 26 | pub path: String, | ^^^^ 27 | pub expiry: i32, | ^^^^^^ 28 | pub lastAccessed: i32, | ^^^^^^^^^^^^ 29 | pub creationTime: i32, | ^^^^^^^^^^^^ 30 | pub isSecure: i32, | ^^^^^^^^ 31 | pub isHttpOnly: i32, | ^^^^^^^^^^ 32 | pub inBrowserElement: i32, | ^^^^^^^^^^^^^^^^ 33 | pub sameSite: i32, | ^^^^^^^^ | = note: `FirefoxCookie` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]`
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/