Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings & Tests for NeMoLLMService #1315

Merged
merged 16 commits into from
Oct 27, 2023
Merged

Docstrings & Tests for NeMoLLMService #1315

merged 16 commits into from
Oct 27, 2023

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 26, 2023 •
edited
Loading

Description

  • Fix logging configuration for llm examples.
  • Fix setting of results for completion pipeline.
  • Log results of completion pipeline.
  • Fix issue where Nemo errors were being silently ignored.
  • Improve handling of nemollm import errors
  • Add tests & docstrings for NeMoLLMClient and NeMoLLMService
  • Create require_env_variable test helper to skip tests that require specific environment variables to be set

Closes #1281

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv self-assigned this Oct 26, 2023
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 26, 2023 17:40
@dagardner-nv dagardner-nv marked this pull request as draft October 26, 2023 17:40
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Oct 26, 2023
@dagardner-nv dagardner-nv changed the title Draft: Tests for NeMoLLMService Docstrings & Tests for NeMoLLMService Oct 26, 2023
@dagardner-nv dagardner-nv marked this pull request as ready for review October 26, 2023 21:44
@dagardner-nv dagardner-nv added the sherlock Issues/PRs related to Sherlock workflows and components label Oct 26, 2023
@dagardner-nv dagardner-nv merged commit 9d26514 into nv-morpheus:fea-sherlock Oct 27, 2023
5 checks passed
@dagardner-nv dagardner-nv deleted the david-fea-sherlock-nemo-service branch October 27, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @drobison00