Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phishing validation fix to match label changes made in PR #1215 #1397

Conversation

dagardner-nv
Copy link
Contributor

Description

  • This PR updated the phishing validation script to match the improvements to the phishing pipeline as documented in the developer guide in PR Phishing example fix #1215.

Closes #1395

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner November 30, 2023 21:36
@dagardner-nv dagardner-nv self-assigned this Nov 30, 2023
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Nov 30, 2023
@dagardner-nv
Copy link
Contributor Author

closing in favor of #1398

@dagardner-nv dagardner-nv deleted the branch-23.11-phishing-val-fix branch April 9, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: phishing validation script fails on labels assertion
2 participants