-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all t2t files, committing generated markdown files in their place, as the the new source of truth. #16144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in userGuide.t2t, which was causing them not to be rendered as tables.
…files as the source of truth.
michaelDCurran
requested review from
Qchristensen and
SaschaCowley
and removed request for
a team
February 7, 2024 22:14
Can you also remove:
|
I'm not sure if we should update the project docs in this PR, but there are references to t2t files in:
|
seanbudd
previously approved these changes
Feb 7, 2024
Co-authored-by: Sean Budd <[email protected]>
seanbudd
added
the
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
label
Feb 12, 2024
SaschaCowley
approved these changes
Feb 14, 2024
I think that would be wise: they already need work, so it's probably best to not let them get even further behind. |
Closing in favour of #16492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
conceptApproved
Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked until final release of 2024.1.
Merging earlier would cause merge conflicts when merging user docs or translated docs from beta to master.
This must be merged before translations begin on the 2024.2beta
Link to issue number:
None.
Summary of the issue:
text2tags is now an old file format, and we need to move to something more standard and maintained.
We are already building markdown files from our t2t files for all languages, so we should simply remove the original t2t files and its support, and commit the generated markdown files.
Description of user facing changes
None. The HTML output is the same.
Description of development approach
Testing strategy:
Known issues with pull request:
None known.
Code Review Checklist: