Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor bug in synth settings ring #16153

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Feb 9, 2024

Link to issue number:

None

Summary of the issue:

_set_currentSettingValue had invalid syntax, with two symbols not being referenced correctly
The function is currently not used in NVDA core, so the bug went unnoticed

Description of user facing changes

None

Description of development approach

Use correct references for symbols.

linting and typing fixes

Testing strategy:

None

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner February 9, 2024 00:19
@AppVeyorBot
Copy link

See test results for failed build of commit 5e723f35c5

@seanbudd seanbudd merged commit 49d5e58 into master Feb 9, 2024
3 checks passed
@seanbudd seanbudd deleted the fixBugSynthSettingsRing branch February 9, 2024 04:48
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Feb 9, 2024
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this pull request Feb 15, 2024
Summary of the issue:
_set_currentSettingValue had invalid syntax, with two symbols not being referenced correctly
The function is currently not used in NVDA core, so the bug went unnoticed

Description of user facing changes
None

Description of development approach
Use correct references for symbols.

linting and typing fixes
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
Summary of the issue:
_set_currentSettingValue had invalid syntax, with two symbols not being referenced correctly
The function is currently not used in NVDA core, so the bug went unnoticed

Description of user facing changes
None

Description of development approach
Use correct references for symbols.

linting and typing fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants