-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra warning to "Installing add-ons" section of User Guide #16510
base: master
Are you sure you want to change the base?
Conversation
Added a new paragraph warning about add-ons and list of ways to verify add-ons to user guide.
@Qchristensen please also see #16316. |
Co-authored-by: Sean Budd <[email protected]>
Co-authored-by: Sean Budd <[email protected]>
Co-authored-by: Cyrille Bougot <[email protected]>
@@ -3387,6 +3387,14 @@ It is very important to only install add-ons from sources you trust. | |||
The functionality of add-ons is unrestricted inside NVDA. | |||
This could include accessing your personal data or even the entire system. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add-ons are scanned by [Virus Total](https://www.virustotal.com/), however, this only detects known malware at submission time. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you want to commit this somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to part of the previous paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially had it at the end of that paragraph, but just reading it again as a whole:
"Just because an add-on is available in the NVDA Add-on Store, does not mean that it has been approved or vetted by NV Access or anyone else. It is very important to only install add-ons from sources you trust. The functionality of add-ons is unrestricted inside NVDA. This could include accessing your personal data or even the entire system."
Perhaps between "... approved or vetted by NV Access or anyone else." and "It is very important to only install add-ons from sources you trust..." would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense to me
Co-authored-by: Sean Budd <[email protected]>
Co-authored-by: Sean Budd <[email protected]>
Following discussion on #16486, the purpose of this PR is to add more warning / ways of verifying add-ons to the add-on section of the User Guide. This can then be referred to from the quick start guide changed proposed in #16486.
Link to issue number:
Summary of the issue:
Intention is to expand on the warning of the risks of add-ons mentioned in the user guide, and offer some suggestions for users to reassure themselves about the author of add-ons prior to installing.
(It should perhaps also be noted, there is no new or additional risk with add-ons than there ever has been. We just want to be sure users are aware of what add-ons are and can do before installing them).
Description of user facing changes
Update user guide with additional paragraph of information.
Description of development approach
Testing strategy:
Known issues with pull request:
Code Review Checklist: