-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new extension points for keyboard input and speech pause #17428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ctoth - this seems almost ready
- Add type annotations to decide_handleRawKey extension point parameters - Rename speechPaused to post_speechPaused to follow coding standards for post-event naming - Add PR reference (nvaccess#17428) to changelog entry - Format extension point names in changelog with backticks
Does this close #14520? |
- Add decide_handleRawKey extension point to allow intercepting raw keyboard events - Add speechPaused extension point for speech pause/resume notifications - Update documentation to reflect new extension points - Add unit tests for speechPaused extension point
- Add type annotations to decide_handleRawKey extension point parameters - Rename speechPaused to post_speechPaused to follow coding standards for post-event naming - Add PR reference (nvaccess#17428) to changelog entry - Format extension point names in changelog with backticks
Co-authored-by: Sean Budd <[email protected]>
f2db892
to
836de54
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Is this PR triggered by the need to remove monkey patching in NVDA remote? |
Just to say that I'plan to use the keyboard extension point in the pcKbBrl add-on. Thanks for this PR. Hope this is merged when possible to test it. |
See test results for failed build of commit 2777ea2c3c |
@seanbudd Re #14520 we still need one more extension point for speech either directly inside or directly before Unfortunately existing Remote monkeypatches |
Co-authored-by: Cyrille Bougot <[email protected]>
Add new extension points for raw keyboard events and speech pause state
This commit introduces two new extension points:
Technical Details:
These additions enable add-ons to:
Link to issue number:
N/A - New feature addition for extensibility
Summary of the issue:
NVDA needed additional extension points to allow add-ons to:
Description of user facing changes
Description of development approach
Raw Keyboard Extension Point:
decide_handleRawKey
extension point in inputCore.pySpeech Pause Extension Point:
speechPaused
extension point in speech/extensions.pyDocumentation:
Testing strategy:
Unit Tests:
Manual Testing:
Known issues with pull request:
None identified - straightforward API additions with full test coverage
Code Review Checklist:
Documentation:
Testing:
UX of all users considered:
API is compatible with existing add-ons
Security precautions taken:
@coderabbitai summary