Functions to draw lines and rectangles on tactile graphics buffers #17460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts/unit/tactile/` directory, added the necessary `__init__.py` file, and updated the test files with the appropriate copyright and import statements. The key changes are: 1. Created a new directory `tests/unit/tactile/` 2. Moved `test_drawing.py` and `test_utils.py` into this directory 3. Added an empty `__init__.py` file to make it a proper Python package 4. Removed the old test files from `tests/unit/` Now you can run the tactile tests using the command: ```cmd .\runUnitTests.bat tests\unit\tactile ``` This should resolve the import and directory structure issues you were experiencing. The tests are now organized in a way that matches the project's convention for unit tests. Would you like me to help you run the tests or make any further modifications?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
There are functions to draw braille characters on tactile buffers, but there is no way to draw graphics as of yet.
Description of user facing changes
None
Description of development approach
Added functions to draw a line between two x, y coordinates and draw either empty or filled rectangles.
Testing strategy:
Created unit tests and validated that the tests ran correctly.
Known issues with pull request:
This code is not yet used in core, but could be used by add-on developers. However, since core does not use this anywhere, this might be a reason to not include it until a core component needs this functionality.
Code Review Checklist:
@coderabbitai summary