Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests to 2.32.3 #17463

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

josephsl
Copy link
Collaborator

@josephsl josephsl commented Dec 1, 2024

Link to issue number:

Closes #17456

Summary of the issue:

NVDA is using requests 2.32.0.

Description of user facing changes

None

Description of development approach

Update requests to 2.32.3.

Testing strategy:

Manual and unit tests: make sure requests functions work after upgrading requests.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@josephsl josephsl requested a review from a team as a code owner December 1, 2024 12:54
@josephsl josephsl requested a review from seanbudd December 1, 2024 12:54
@seanbudd seanbudd merged commit 935e802 into nvaccess:master Dec 1, 2024
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Dec 1, 2024
@josephsl josephsl deleted the requests-2.32.3 branch December 2, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update requests to 2.32.3
2 participants