Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Powerpoint say all on new slide #17498

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

Follow up of #17488

Summary of the issue:

Since #17488, entering a slide show in Power point no longer activates say all when that browse mode option is disabled. However, I intended this to also apply to cases where you'd move from one slide to another, which didn't work.

Description of user facing changes

NO say all when moving from slide to slide in a slide show and the browse mode option is disabled.

Description of development approach

Expanded the reportSlide method.

Testing strategy:

Tested moving from slide to slide with say all on page load enabled and disabled.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner December 10, 2024 19:56
@seanbudd seanbudd merged commit 02736c8 into nvaccess:master Dec 10, 2024
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants