Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create experts contact list #17511

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Create experts contact list #17511

wants to merge 8 commits into from

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Dec 13, 2024

Link to issue number:

None

Summary of the issue:

It is unclear who to tag on issues and pull requests.
Contributors require insider knowledge on who should be tagged on relevant issues/PRs.
Other projects such as Python and wxWidgets maintain experts lists to make communicating with the community easier.

Description of user facing changes

Add an experts list for community contact

Suggested topics

CI/CD, Scons / build, C++, wx / GUI, Add-on Store, i18n infra, Braille, Audio, Mouse, Speech, Web browsers, MS Office, Windows interface, Java apps, Virtual buffers, LibreOffice, Docs, Testing / QA, Dependency maintenance

Known issues

It would be ideal to use GitHub teams however these cannot be made publicly visible.
See discussion https://github.com/orgs/community/discussions/146973

@seanbudd
Copy link
Member Author

seanbudd commented Dec 13, 2024

cc @LeonarddeR @josephsl @CyrilleB79 @lukaszgo1 @codeofdusk @XLTechie @mltony @Adriani90 @nvdaes @michaelweghorn @mwhapples (and others untagged!)

Feel free to add a review suggestion adding yourself to the list with relevant topics you are comfortable being tagged on.
Also feel free to include/not include your email as desired.

| @SaschaCowley | <[email protected]> | Issue triage, technical decisions |
| @michaelDCurran | <[email protected]> | Advanced technical consulting |
| @Qchristensen | <[email protected]> | User documentation, user support |
| @jcsteh | <[email protected]> | Firefox bugs |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcsteh - confirming you're okay being added to this list, and can this be expanded to web browser bugs in general?

@seanbudd seanbudd changed the title Create experts list Create experts contact list Dec 13, 2024
@nvdaes
Copy link
Collaborator

nvdaes commented Dec 13, 2024

@seanbudd , thanks for your consideration tagging me. Perhaps you can suggest a list of topics, and experts should be sortered by topic, for example, hypotetical:
Windows: @josephsl x, y z contributors.
Other topic: @LeonarddeR , @CyrilleB79 , etc.

Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, thanks @seanbudd

projectDocs/community/expertsList.md Outdated Show resolved Hide resolved
@seanbudd
Copy link
Member Author

@nvdaes - I added a list of topics to the PR description

Co-authored-by: Sascha Cowley <[email protected]>
Co-authored-by: Bill Dengler <[email protected]>
@seanbudd
Copy link
Member Author

@nvdaes - we may consider restructuring this as topic based as suggested, however the current format is more ideal for now to generate the list

@nvdaes
Copy link
Collaborator

nvdaes commented Dec 13, 2024

Sean wrote:

we may consider restructuring this as topic based as suggested, however the current format is more ideal for now to generate the list

OK. I think that sortering this by topics with headings would make easier to tag people. Otherwise we need to search who is assigned for each topic.
Also, you may want to add a comment about how to proceed to be added to a different topic or removed. For example:

If an expert wants to be updated or removed from the list, please create a PR, or contact NV Access, etc.

@nvdaes
Copy link
Collaborator

nvdaes commented Dec 13, 2024

Also, I think that a link to this document may be added to the issue template.

@josephsl
Copy link
Collaborator

josephsl commented Dec 13, 2024

Hi,

While I can't devote much time to NVDA community expertise, I can serve as a point of contact for the following topics: Windows Insider builds, emoji panel and other modern keyboard features, Windows user interface, touchscreen.

Thanks.

@nvdaes
Copy link
Collaborator

nvdaes commented Dec 13, 2024

@seanbudd and @SaschaCowley , I think that Math support is a topic with sufficient entity to be added, since it involves braille, speach, navigation and different formats and documents. @NSoiffer may want to be added.

@seanbudd
Copy link
Member Author

@nvdaes

Also, you may want to add a comment about how to proceed to be added to a different topic or removed. For example:

I don't think we have settled on a procedure yet - but like anything, people can always open a PR.
After this initial list is generated we may directly contact contributors to suggest they add themselves.

Also, I think that a link to this document may be added to the issue template.

Could you please elaborate where and why you think this should be added? I think it may add unnecessary extra noise to first time contributors. I would prefer to avoid a culture where every issue that is submitted involves a tag. NV Access collectively reviews all submitted issues through triage.

I think that Math support is a topic with sufficient entity to be added, since it involves braille, speech, navigation and different formats and documents.

The suggested list above is non-exhaustive, as Bill, Joseph and yourself have done, folks can add the specific topics as desired


@josephsl - can you add a review suggestion or confirm if you are comfortable with your email being added

@LeonarddeR
Copy link
Collaborator

@seanbudd What @josephsl said with regard to available time also applies to me. I'm not sure whether I feel comfortable being added to such a list when it creates the potential to be tagged with every issue. May be it can help to distinguish between first-line and second-line experts. If you then appoint a first-line and second-line expert for each topic and clearly indicate that a second-line expert functions more in the background and is ideally involved in an issue by a first-line expert, I think this can make the necessary difference. Of course I am happy to contribute if strictly necessary and time is available.

For the above topics, I'm happy to be added to the Braille topic as second lien expert.

@nvdaes
Copy link
Collaborator

nvdaes commented Dec 13, 2024

@seanbudd

Could you please elaborate where and why you think this should be added? I think it may add unnecessary extra noise to first time contributors. I would prefer to avoid a culture where every issue that is submitted involves a tag. NV Access collectively reviews all submitted issues through triage.

In this case don't add it to the template please.

@seanbudd
Copy link
Member Author

@LeonarddeR @josephsl how about a column or asterisk noting activity level?

| GitHub | email | topics |
|---|---|---|
| @codeofdusk | <[email protected]> | Windows Terminal and console, Microsoft UI Automation |
| @nvdaes | <[email protected]> | Add-on store, braille |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with being tagged on LibreOffice-related issues/PRs.

Just as an idea: Would it make sense to switch the order, i.e. list the topic first, then the contact person? (My expectation would be that people looking into this document would usually first search for the topic, then look into the other columns.)

Suggested change
| @nvdaes | <[email protected]> | Add-on store, braille |
| @nvdaes | <[email protected]> | Add-on store, braille |
| @michaelweghorn | <[email protected]> | LibreOffice |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants