Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font awesome to latest version and usage #358

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

tksheppard
Copy link
Collaborator

Related to Issue

Fixes #357

Description

  • Updated the fontawesome free version to most recent (6.5.1)
  • Changed the font usage to only include the free Webfonts and CSS within the gulpfile
  • Updated includes to use correct CSS and Webfonts

How Has This Been Tested?

Made updates, ran gulp. Compiled and checked on local environment to make sure no errors.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tksheppard
Copy link
Collaborator Author

@david-poindexter I know we discussed multiple PR's, but I noticed issue #358 already outlined the necessary changes to font usage and include updates.

It's still tossing the warnings that @dnndiva was speaking about earlier, but I'm not sure what to do about these. This seems like a new warning. I even tried making sure the page is using fontawesome and it still gives these warnings.
image

@david-poindexter
Copy link
Member

@david-poindexter I know we discussed multiple PR's, but I noticed issue #358 already outlined the necessary changes to font usage and include updates.

It's still tossing the warnings that @dnndiva was speaking about earlier, but I'm not sure what to do about these. This seems like a new warning. I even tried making sure the page is using fontawesome and it still gives these warnings. image

@tksheppard it is totally fine for this to all be in one PR - thank you!

As it relates to the warning, this is for a woff file. At this point, I see no reason why need to continue including woff files. woff2 is supported now on all modern browsers. I will approve this PR and I'll create a separate issue for the drop of woff support in nvQuickTheme.

@david-poindexter david-poindexter added the enhancement New feature or request label Dec 28, 2023
@david-poindexter david-poindexter added this to the 3.1.0 milestone Dec 28, 2023
@david-poindexter david-poindexter merged commit 1079293 into develop Dec 28, 2023
3 checks passed
@david-poindexter david-poindexter deleted the update-font-awesome branch December 28, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade FontAwesome to latest (currently 6.5.1)
2 participants