[New] install.sh: add $ZDOTDIR to zsh search
#3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
shell: zsh
installing nvm: profile detection
ljharb
changed the title
install.sh: add $ZDOTDIR to zsh search
|
hmm, one of the tests is failing on master, but it passed on the PR |
ljharb
pushed a commit
to menaechmi/nvm
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install for zsh currently fails if you use
$ZDOTDIRto change where the zsh files are located - see #3128. This is a simple way to make nvm find them first and then default to$HOMEif unset. I tested it with$ZDOTDIR/.zprofileand$ZDOTDIR/.zshrc, as well as an unset$ZDOTDIRfor both and it works.I added a few tests for it, but I couldn't see if the tests actually worked right - all I get is
Error: the install instructions explicitly say to pipe the install script to bash; please follow them. I wrote them to follow the existing structure.After starting this, I did find #3365 (whoops) - I think this implementation is a little better by not relying on .zshenv (which can also be placed in the ZDOTDIR)