Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button color fix #522

Merged
merged 2 commits into from
Nov 14, 2023
Merged

button color fix #522

merged 2 commits into from
Nov 14, 2023

Conversation

samanthatuhseng
Copy link
Contributor

Description

Changing button color fix according to figma design.

Other considerations

Screenshot 2023-11-14 at 2 27 06 PM Screenshot 2023-11-14 at 2 29 15 PM

Copy link

github-actions bot commented Nov 14, 2023

Visit the preview URL for this PR (updated for commit 9b489f6):

https://nwplus-ubc--pr522-peer-judging-changes-uhttka2t.web.app

(expires Tue, 21 Nov 2023 22:47:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

minor fix

  • make text in button on 1 line
    e.g
    image

@DonaldKLee
Copy link
Member

lgtm

minor fix

  • make text in button on 1 line
    e.g
    image

image

@samanthatuhseng
Copy link
Contributor Author

Screenshot 2023-11-14 at 2 42 27 PM Here you go Donald.

@DonaldKLee
Copy link
Member

Screenshot 2023-11-14 at 2 42 27 PM Here you go Donald.

Great job Sam. Very proud of your achievement :)

@DonaldKLee DonaldKLee self-requested a review November 14, 2023 22:48
@DonaldKLee DonaldKLee merged commit a73e403 into dev Nov 14, 2023
2 checks passed
@meleongg meleongg deleted the peer-judging-changes branch November 14, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants