Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erping/rewards #628

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Erping/rewards #628

merged 5 commits into from
Oct 31, 2024

Conversation

ErpingS
Copy link
Contributor

@ErpingS ErpingS commented Oct 26, 2024

Description

Added the total points components on the rewards page

Screenshot 2024-10-26 at 1 57 05 PM

Other considerations

Copy link
Contributor

@daniel-panhead daniel-panhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wondering on where we will be storing user attended events, we might need to discuss this

useEffect(() => {
;(async () => {
if (userDetails && dbHackathonName) {
const eventIds = userDetails.events.map(event => event.eventId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last year the user attended events were stored under userDetails.dayOf.events - but not sure if that has changed this year

Copy link

Visit the preview URL for this PR (updated for commit f32ff52):

https://nwplus-ubc--pr628-erping-rewards-f5isaa2i.web.app

(expires Thu, 07 Nov 2024 02:30:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@ErpingS ErpingS merged commit f72e1d9 into dev Oct 31, 2024
2 checks passed
@ErpingS ErpingS deleted the erping/rewards branch October 31, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants