Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap getAndAssignProjects with db.runTransaction #629

Merged
merged 29 commits into from
Oct 29, 2024
Merged

Conversation

tdanielles
Copy link
Contributor

Description

  • wrap getAndAssignProjects with db.runTransaction as an attempt to fix a potential race condition that happens when projects are being assigned

Copy link

github-actions bot commented Oct 29, 2024

Visit the preview URL for this PR (updated for commit 8140c9a):

https://nwplus-ubc--pr629-peer-judging-bug-oh4x2878.web.app

(expires Tue, 05 Nov 2024 02:42:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

Copy link
Contributor

@martincai8 martincai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! would it be possible this in a try catch so we can debug on the day of if needed 😰

@tdanielles tdanielles merged commit 038b124 into dev Oct 29, 2024
2 checks passed
@tdanielles tdanielles deleted the peer-judging-bug branch October 29, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants