-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socials #175
Add socials #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes lgtm, left a comment for a minor change. I wonder why the deploy has failed- would fixing eslint fix it?
Visit the preview URL for this PR (updated for commit c2d6e92): https://nwplus-io--pr175-add-socials-cmnk4r8z.web.app (expires Wed, 25 Oct 2023 00:38:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d |
@michelleykim should we also turn the "join the team" button off with this pr? |
ooh yeah thatd be nice @DonaldKLee can u change this too lol luv u |
done! did not need to touch the code for this. this is a firebase flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!
Added 1st year rep to the website
Hyperlinked each member with their socials