Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socials #175

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Add socials #175

merged 5 commits into from
Oct 24, 2023

Conversation

DonaldKLee
Copy link
Member

Added 1st year rep to the website
Hyperlinked each member with their socials

@DonaldKLee DonaldKLee linked an issue Oct 16, 2023 that may be closed by this pull request
Copy link
Contributor

@michelleykim michelleykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes lgtm, left a comment for a minor change. I wonder why the deploy has failed- would fixing eslint fix it?

components/Footer.js Outdated Show resolved Hide resolved
@DonaldKLee
Copy link
Member Author

the changes lgtm, left a comment for a minor change. I wonder why the deploy has failed- would fixing eslint fix it?

@naijwu @meleongg do yk why the deploy is failing? seems to be a firebase issue

@meleongg
Copy link
Member

Try running yarn lint locally, it looks like there's a React child key error

also can you add my social LOLLL I thought I updated it xd

image

components/Team.js Outdated Show resolved Hide resolved
@meleongg
Copy link
Member

There's an unused variable causing lint errors. Does yarn build work when you run locally - it should throw linting errors

image image

@DonaldKLee
Copy link
Member Author

There's an unused variable causing lint errors. Does yarn build work when you run locally - it should throw linting errors

image image

fixed!

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit c2d6e92):

https://nwplus-io--pr175-add-socials-cmnk4r8z.web.app

(expires Wed, 25 Oct 2023 00:38:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d

@meleongg
Copy link
Member

@michelleykim should we also turn the "join the team" button off with this pr?

image

@michelleykim
Copy link
Contributor

@michelleykim should we also turn the "join the team" button off with this pr?

image

ooh yeah thatd be nice @DonaldKLee can u change this too lol luv u

@DonaldKLee
Copy link
Member Author

@michelleykim should we also turn the "join the team" button off with this pr?
image

ooh yeah thatd be nice @DonaldKLee can u change this too lol luv u

done! did not need to touch the code for this. this is a firebase flag

Copy link
Contributor

@michelleykim michelleykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@DonaldKLee DonaldKLee merged commit b1fdd9c into main Oct 24, 2023
2 checks passed
@DonaldKLee DonaldKLee deleted the add-socials branch October 24, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add socials to www
3 participants