Add nwHacks registrations temporarily closed banner #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit beaf213): https://nwplus-io--pr177-banner-2jod83vq.web.app (expires Tue, 21 Nov 2023 21:13:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d |
|
I'm getting some sidescroll in the preview |
|
@meleongg Sorry how can I reproduce this? |
meleongg
reviewed
Nov 14, 2023
components/Banner.js
Outdated
| position: absolute; | ||
| z-index: 1; | ||
| height: 134px; | ||
| width: 100vw; |
There was a problem hiding this comment.
I suspect the sidescroll may be coming from the width
|
side scroll is fixed, but the banner covers a bit of the background on mobile - using iPhone 12 Pro 
|
meleongg
reviewed
Nov 14, 2023
|
|
||
| const BannerContainer = styled.div` | ||
| background: linear-gradient(92.58deg, #0defe1 0%, #78ff96 100%); | ||
| position: absolute; |
There was a problem hiding this comment.
I'm wondering if it's possible to shift the hero down such that the banner isn't covering it? or do you think it looks good enough already haha
- removing position: absolute; looks to fix it on mobile but I haven't thoroughly checked this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds banner to top of website saying nwHacks registrations are temporarily closed.
Other considerations
Might be nice to align the text in another PR, for now just copied design component.