Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Improve element parsing #15

Merged
merged 6 commits into from
Nov 10, 2016
Merged

Improve element parsing #15

merged 6 commits into from
Nov 10, 2016

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Oct 31, 2016

@coveralls
Copy link

coveralls commented Oct 31, 2016

Coverage Status

Coverage increased (+0.02%) to 77.766% when pulling 4238b21 on classes_before_ids_2 into cf8c454 on master.

@coveralls
Copy link

coveralls commented Oct 31, 2016

Coverage Status

Coverage increased (+0.02%) to 77.766% when pulling 4238b21 on classes_before_ids_2 into cf8c454 on master.

@coveralls
Copy link

coveralls commented Oct 31, 2016

Coverage Status

Coverage increased (+0.02%) to 77.766% when pulling b7ddfa1 on classes_before_ids_2 into cf8c454 on master.

@rowanseymour rowanseymour self-assigned this Oct 31, 2016
@coveralls
Copy link

coveralls commented Oct 31, 2016

Coverage Status

Coverage increased (+0.02%) to 77.766% when pulling 2bcf074 on classes_before_ids_2 into cf8c454 on master.

@rowanseymour
Copy link
Member Author

@Psycojoker please review when you get a chance

@coveralls
Copy link

coveralls commented Nov 8, 2016

Coverage Status

Coverage increased (+0.02%) to 80.485% when pulling 9880acc on classes_before_ids_2 into 3aafc5c on master.

@rowanseymour
Copy link
Member Author

@Psycojoker sorry to pester but really want to get this merged this week if possible

@Psycojoker
Copy link
Collaborator

@rowanseymour gonna try to look at this this evening, sorry I'm really busy right now :/

@Psycojoker Psycojoker merged commit 9880acc into master Nov 10, 2016
@Psycojoker
Copy link
Collaborator

Sorry, took me a bit of time to fully review your changes. They do improve code readability, thanks for that :)

@Psycojoker
Copy link
Collaborator

Tell me if you feel confident enough for a release.

@rowanseymour rowanseymour deleted the classes_before_ids_2 branch November 11, 2016 10:22
@rowanseymour
Copy link
Member Author

Yes please make one

@Psycojoker
Copy link
Collaborator

https://pypi.python.org/pypi/django-hamlpy/0.86

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element id is ignored when given after classes Should support tag names with hyphens
3 participants