Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of aberration corrections #153

Merged
merged 21 commits into from
Jan 9, 2024

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented Jan 1, 2024

Summary

Add aberration corrections.

Closes #26 .

Architectural Changes

No change

New Features

Can now query BSP/SPK files while accounting for aberrations in either the reception or transmission cases, with a single light-time correction or in "converged" (three iterations), and optionally including stellar aberrations.

Improvements

No change

Bug Fixes

No change

Testing and validation

  • TODO: Add a new set of validation cases

Documentation

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (030d470) 77.14% compared to head (d78bc23) 76.27%.
Report is 4 commits behind head on master.

❗ Current head d78bc23 differs from pull request most recent head 72b0d47. Consider uploading reports for the commit 72b0d47 to get more accurate results

Files Patch % Lines
anise/src/astro/aberration.rs 2.17% 45 Missing ⚠️
anise/src/ephemerides/translate_to_parent.rs 28.57% 40 Missing ⚠️
anise/src/math/mod.rs 0.00% 22 Missing ⚠️
anise/src/ephemerides/translations.rs 25.00% 3 Missing ⚠️
anise/src/astro/orbit.rs 0.00% 1 Missing ⚠️
anise/src/math/cartesian.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   77.14%   76.27%   -0.88%     
==========================================
  Files          67       67              
  Lines        7815     7907      +92     
==========================================
+ Hits         6029     6031       +2     
- Misses       1786     1876      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit edb43c7 into master Jan 9, 2024
20 checks passed
@ChristopherRabotin ChristopherRabotin deleted the 26-support-of-aberration-corrections branch January 9, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of aberration corrections
1 participant