Fix transformation when it involved multi-barycenter hops

.github/workflows/benchmarks.yml

@@ -27,6 +27,7 @@ jobs:
           wget -O data/gmat-hermite.bsp http://public-data.nyxspace.com/anise/ci/gmat-hermite.bsp
           wget -O data/variable-seg-size-hermite.bsp http://public-data.nyxspace.com/anise/ci/variable-seg-size-hermite.bsp
           wget -O data/earth_latest_high_prec.bpc http://public-data.nyxspace.com/anise/ci/earth_latest_high_prec-2023-09-08.bpc
+          wget -O data/lro.bsp http://public-data.nyxspace.com/nyx/examples/lrorg_2023349_2024075_v01_LE.bsp
 
       - name: Install stable toolchain
         uses: dtolnay/rust-toolchain@stable

.github/workflows/rust.yml

@@ -50,6 +50,7 @@ jobs:
           wget -O data/gmat-hermite.bsp http://public-data.nyxspace.com/anise/ci/gmat-hermite.bsp
           wget -O data/variable-seg-size-hermite.bsp http://public-data.nyxspace.com/anise/ci/variable-seg-size-hermite.bsp
           wget -O data/earth_latest_high_prec.bpc http://public-data.nyxspace.com/anise/ci/earth_latest_high_prec-2023-09-08.bpc
+          wget -O data/lro.bsp http://public-data.nyxspace.com/nyx/examples/lrorg_2023349_2024075_v01_LE.bsp
 
       - name: Install stable toolchain
         uses: dtolnay/rust-toolchain@stable
@@ -111,6 +112,7 @@ jobs:
           wget -O data/gmat-hermite.bsp http://public-data.nyxspace.com/anise/ci/gmat-hermite.bsp
           wget -O data/variable-seg-size-hermite.bsp http://public-data.nyxspace.com/anise/ci/variable-seg-size-hermite.bsp
           wget -O data/earth_latest_high_prec.bpc http://public-data.nyxspace.com/anise/ci/earth_latest_high_prec-2023-09-08.bpc
+          wget -O data/lro.bsp http://public-data.nyxspace.com/nyx/examples/lrorg_2023349_2024075_v01_LE.bsp
 
       - name: Install stable toolchain
         uses: dtolnay/rust-toolchain@stable
@@ -179,6 +181,7 @@ jobs:
           wget -O data/gmat-hermite.bsp http://public-data.nyxspace.com/anise/ci/gmat-hermite.bsp
           wget -O data/variable-seg-size-hermite.bsp http://public-data.nyxspace.com/anise/ci/variable-seg-size-hermite.bsp
           wget -O data/earth_latest_high_prec.bpc http://public-data.nyxspace.com/anise/ci/earth_latest_high_prec-2023-09-08.bpc
+          wget -O data/lro.bsp http://public-data.nyxspace.com/nyx/examples/lrorg_2023349_2024075_v01_LE.bsp
 
       - name: Install stable toolchain
         uses: dtolnay/rust-toolchain@stable

.gitignore

@@ -13,3 +13,4 @@ cspice.tar.Z
 *.epa
 anise-gui/dist/
 anise-py/notebooks/.ipynb_checkpoints/ANISE Tutorial for querying SPK files-checkpoint.ipynb
+data/lro.bsp

anise/build.rs

@@ -28,7 +28,11 @@ fn main() {
 
     // Create the directory if it doesn't exist
     if !data_path.exists() {
-        fs::create_dir_all(&data_path).expect(&format!("failed to create directory {data_path:?}"));
+        if let Err(e) = fs::create_dir_all(&data_path) {
+            eprintln!("EMBEDDED EPHEM UNAVAILABLE: failed to create directory {data_path:?}");
+            // Try nothing else.
+            return;
+        }
     }
 
     for (url, dest_path) in embedded_files {

anise/src/ephemerides/paths.rs

@@ -179,14 +179,14 @@ impl Almanac {
                         return Ok((items, common_path, to_frame.ephemeris_id));
                     }
 
+                    common_path[items] = Some(from_obj.unwrap());
+                    items += 1;
+
                     if from_obj == to_obj {
                         // This is where the paths branch meet, so the root is the parent of the current item.
                         // Recall that the path is _from_ the source to the root of the context, so we're walking them
                         // backward until we find "where" the paths branched out.
                         return Ok((items, common_path, to_obj.unwrap()));
-                    } else {
-                        common_path[items] = Some(from_obj.unwrap());
-                        items += 1;
                     }
                 }
             }

anise/src/ephemerides/translations.rs

@@ -66,7 +66,7 @@ impl Almanac {
 
         match ab_corr {
             None => {
-                let (node_count, path, common_node) =
+                let (node_count, _path, common_node) =
                     self.common_ephemeris_path(observer_frame, target_frame, epoch)?;
 
                 // The fwrd variables are the states from the `from frame` to the common node
@@ -85,7 +85,7 @@ impl Almanac {
                         self.translation_parts_to_parent(target_frame, epoch)?
                     };
 
-                for cur_node_id in path.iter().take(node_count) {
+                for _ in 0..node_count {
                     if !frame_fwrd.ephem_origin_id_match(common_node) {
                         let (cur_pos_fwrd, cur_vel_fwrd, cur_frame_fwrd) =
                             self.translation_parts_to_parent(frame_fwrd, epoch)?;
@@ -103,11 +103,6 @@ impl Almanac {
                         vel_bwrd += cur_vel_bwrd;
                         frame_bwrd = cur_frame_bwrd;
                     }
-
-                    // We know this exist, so we can safely unwrap it
-                    if cur_node_id.unwrap() == common_node {
-                        break;
-                    }
                 }
 
                 Ok(CartesianState {

anise/tests/ephemerides/transform.rs

@@ -8,7 +8,7 @@
  * Documentation: https://nyxspace.com/
  */
 
-use anise::constants::frames::{EARTH_ITRF93, IAU_MOON_FRAME, MOON_J2000, VENUS_J2000};
+use anise::constants::frames::{EARTH_ITRF93, IAU_MOON_FRAME, MOON_J2000, SUN_J2000, VENUS_J2000};
 use anise::math::Vector3;
 use anise::prelude::*;
 
@@ -192,3 +192,54 @@ fn spice_verif_iau_moon() {
     assert!(rss_pos_km < 0.004);
     assert!(rss_vel_km_s < 1e-5);
 }
+
+#[test]
+fn gh_283_multi_barycenter() {
+    let almanac = MetaAlmanac::default()
+        .process(true)
+        .unwrap()
+        .load("../data/lro.bsp")
+        .unwrap();
+
+    const LRO_ID: i32 = -85;
+    let lro_frame = Frame::from_ephem_j2000(LRO_ID);
+
+    let epoch = Epoch::from_gregorian_utc_at_midnight(2024, 1, 1);
+
+    // First, let's test that the common ephemeris path is correct
+    let (node_count, path, common_node) = almanac
+        .common_ephemeris_path(lro_frame, SUN_J2000, epoch)
+        .unwrap();
+
+    assert_eq!(common_node, 0, "common node should be the SSB");
+    assert_eq!(node_count, 3, "node count should be Moon, EMB, SSB");
+    assert_eq!(
+        path,
+        [Some(301), Some(3), Some(0), None, None, None, None, None,],
+        "node count should be Moon, EMB, SSB"
+    );
+
+    let spice_lro_state = Orbit::new(
+        -25181236.12671419,
+        133176946.34310651,
+        57755823.14607649,
+        -31.33683951,
+        -4.57447104,
+        -1.6316696,
+        epoch,
+        SUN_J2000,
+    );
+
+    let anise_lro_state = almanac
+        .transform(lro_frame, SUN_J2000, epoch, None)
+        .unwrap();
+
+    println!("ANISE\n{anise_lro_state}\nSPICE\n{spice_lro_state}");
+    let rss_pos_km = anise_lro_state.rss_radius_km(&spice_lro_state).unwrap();
+    let rss_vel_km_s = anise_lro_state.rss_velocity_km_s(&spice_lro_state).unwrap();
+
+    dbg!(rss_pos_km, rss_vel_km_s);
+
+    assert!(rss_pos_km < f64::EPSILON);
+    assert!(rss_vel_km_s < 1e-8);
+}