Support SPK Type 3 chebyshev position and velocity #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach does not work because the data is always returned as a type2 record, when it should be a type 3. I'm afraid this will require code duplication unless I implement a major architectural change. |
The abstraction barely reduced code duplication but greatly increased complexity
ChristopherRabotin
deleted the
320-support-spk-type-3-chebyshev-position-and-velocity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for SPK type 3 BSP
Fix #320
Architectural Changes
No public changes.
Internally, because the dataset for type 2 and type 3 Chebyshev is identical, I've created a private trait that avoids code duplication.
New Features
Support SPK type3 Chebyshev interpolation.
Improvements
No change
Bug Fixes
No change
Testing and validation
A new DE440-type3 BSP file is added to the tests and validated as part of the validation suite. This file is also used in one of the integration tests.
Documentation
This PR does not primarily deal with documentation changes.