Fix issues with version.json and extra env declaration

oZakari · Jul 30, 2024 · 5591305 · 5591305
1 parent a789864
commit 5591305
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/avm/res/app/container-app/README.md b/avm/res/app/container-app/README.md
@@ -29,7 +29,7 @@ The following section provides usage examples for the module, which were used to
 
 - [Using only defaults](#example-1-using-only-defaults)
 - [Without ingress enabled](#example-2-without-ingress-enabled)
-- [Max](#example-3-max)
+- [Using large parameter set](#example-3-using-large-parameter-set)
 - [VNet integrated container app deployment](#example-4-vnet-integrated-container-app-deployment)
 - [WAF-aligned](#example-5-waf-aligned)
 
@@ -185,7 +185,10 @@ module containerApp 'br/public:avm/res/app/container-app:<version>' = {
 </details>
 <p>
 
-### Example 3: _Max_
+### Example 3: _Using large parameter set_
+
+This instance deploys the module with most of its features enabled.
+
 
 <details>
 
@@ -200,8 +203,8 @@ module containerApp 'br/public:avm/res/app/container-app:<version>' = {
       {
         env: [
           {
-            name: 'test'
-            value: 'max'
+            name: 'TestGuid'
+            secretRef: 'customtest'
           }
         ]
         image: 'mcr.microsoft.com/azuredocs/containerapps-helloworld:latest'
@@ -293,8 +296,8 @@ module containerApp 'br/public:avm/res/app/container-app:<version>' = {
         {
           "env": [
             {
-              "name": "test",
-              "value": "max"
+              "name": "TestGuid",
+              "secretRef": "customtest"
             }
           ],
           "image": "mcr.microsoft.com/azuredocs/containerapps-helloworld:latest",

diff --git a/avm/res/app/container-app/tests/e2e/max/main.test.bicep b/avm/res/app/container-app/tests/e2e/max/main.test.bicep
@@ -131,12 +131,6 @@ module testDeployment '../../../main.bicep' = [
               periodSeconds: 3
             }
           ]
-          env: [
-            {
-              name: 'test'
-              value: 'max'
-            }
-          ]
         }
       ]
     }

diff --git a/avm/res/app/container-app/version.json b/avm/res/app/container-app/version.json
@@ -1,6 +1,6 @@
 {
   "$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
-  "version": "v0.7-1",
+  "version": "0.7",
   "pathFilters": [
     "./main.json"
   ]
-Original file line number
+Diff line change
@@ Expand Up / @@ -131,12 +131,6 @@ module testDeployment '../../../main.bicep' = [ @@
                   periodSeconds: 3
                 }
               ]
-              env: [
-                {
-                  name: 'test'
-                  value: 'max'
-                }
-              ]
             }
           ]
         }
@@ Expand Down @@