Add T&C #443
Add T&C #443
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oacore/dashboard/h3k2mvjow |
|
@viktor-yakubiv Feel free to review. Everything is ready but text hence keeping it as a draft till it's solved. |
There was a problem hiding this comment.
Use for the inspiration:
All of them have similar layout: table of contents at the left sidebar and actual text at the right side. As an experiment, we can move ToC to the right side. Also, I see /terms is more popular and simple URL for it.
I am not sure that you did this in the right place. Perhaps it should be under core.ac.uk/terms
|
|
@viktor-yakubiv Can you please rebase and remove |
|
I am impressed by my solution of the counters problem! 😄 |
|
In my ideal scenario, we stick with Markdown but setup wrapping headlines (everything between and including headlines) into appropriate sections. It can be done via a remark-plugin (perhaps, we will need to write it) but the problem of the plugin is that it's not possible to handle such (rare or maybe impossible case): <main>
<h1>Article Title</h1>
<p>Paragraph 1</p>
<section>
<h2>Section 1 Title</h2>
<p>Section 1 paragraph</p>
</section>
<p>Paragraph 2</p>
<section>
<h2>Section 2 Title</h2>
<p>Section 2 paragraph</p>
</section>
<p>Paragraph 3</p>
</main>As a compromise, we could stick with the HTML what is even more flexible but a bit heavier to write. That is why I considered that we might need MDX, where we can have Markdown with some HTML enhancements and even JSX. However, it proper setup to stay consistent with the rest of the code. |
|
Furthermore, it would be nice to unify everything using a Webpack loader (actually, a plugin) that loads for Yaml, Markdown, and MDX (with YAML frontmatter) and turns it into a template that has a similar interface for different types of entities. I checked awesome-webpack but could not find anything that fits our needs. Despite, I found a few that might be useful for us or just funny: I am afraid we will need to write something and this even feels interesting to me 🙂 |
|
@viktor-yakubiv There are some attributes errors in console. Not sure if you are aware 🙂 |
|
Be sure, I'm not. I check the console output only when something doesn't work 😄 |
|
@Joozty thank you for your comment. Check the fix 😄 |
We need MDX for enhanced sections in the Terms and Conditions markdown file. @mdx-js/react especially is needed to use MDXProvider to pass custom components down to the page.
Adds Section and Heading which lave deepness levels calculated based on the React Context.
Creates 'legal' section in the texts and puts a 'terms.mdx' in there. Created Terms page with basics content page styling. Setups MDX context for custom components support on the page. Adds enumeration for the section headlines on the page.
|
Deployment failed with the following error: |
No description provided.