Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added typescript types #15

Merged
merged 15 commits into from
Feb 25, 2022
Merged

added typescript types #15

merged 15 commits into from
Feb 25, 2022

Conversation

danielgamage
Copy link
Member

rollup now emits typescript declaration files (.d.ts) for each of our entry files in the distribution folder for static type checking. also allows for some easier inline documentation. just need to publish and make sure the declaration files get detected properly in the package.

dist/
  web-component.js
  web-component.d.ts
  react-component.js
  react-component.d.ts
  ...

@danielgamage
Copy link
Member Author

danielgamage commented Jan 10, 2022

support for the package.json exports field, which we use, was removed until at least 4.6 (looks like 4.7 now). trying to find a workaround to ship this prior to that (probably February 22nd)

@danielgamage danielgamage marked this pull request as ready for review February 25, 2022 19:08
@danielgamage
Copy link
Member Author

danielgamage commented Feb 25, 2022

i'm not actually having the issues in typescript that i thought i would anymore, so i'm going to merge, release, then double-check our other demos

edit: totally kidding but i think i have a workaround in moving things out of dist/ and importing files directly

@danielgamage danielgamage merged commit 31c08ed into main Feb 25, 2022
@danielgamage danielgamage deleted the types/init branch February 25, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant