Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/runtime: Fix outdated storage nodes refs #5955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martintomazic
Copy link

Storage nodes are the artifact of the past? This MR removes references to them in the runtime/docs.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for oasisprotocol-oasis-core ready!

Name Link
🔨 Latest commit 2b603fe
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/67517e1e60853400088a9687
😎 Deploy Preview https://deploy-preview-5955--oasisprotocol-oasis-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@martintomazic
Copy link
Author

Do we make changelog even for such trivial PRs?

@ptrus
Copy link
Member

ptrus commented Dec 3, 2024

Do we make changelog even for such trivial PRs?

We usually create empty xxx.trivial.md changelog fragements for trivial changes. e.g. https://github.com/oasisprotocol/oasis-core/blob/master/.changelog/5591.trivial.md

@martintomazic martintomazic force-pushed the martin/fix/runtime-layer-docs branch from 04ac1ce to a378b28 Compare December 3, 2024 08:44
@peternose
Copy link
Contributor

https://github.com/oasisprotocol/oasis-core/blob/master/CONTRIBUTING.md

@martintomazic martintomazic force-pushed the martin/fix/runtime-layer-docs branch from a378b28 to 2b603fe Compare December 5, 2024 10:19
@kostko kostko removed their assignment Dec 13, 2024
@@ -3,7 +3,6 @@
Oasis Core nodes communicate between themselves over various protocols. One of
those protocols is [gRPC] which is currently used for the following:

* Compute nodes talking to storage nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire list is no longer true as we do not use gRPC for inter-node communication. We have been using a libp2p-based protocol for a long while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants