Add concat_slice and mark everything as unsafe
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chooses the very cautious option of erroring in all cases of a ZST concatentation.
Adding a trait to the interface that can not be implemented seems to complicate the interface (it requires an additional indirection to find the valid uses). I'd either rename the methods to |
See issue oberien#7, we must guarantee that slices are from the same allocation. However, pointer equality testing can not reliably test this so it must be provided by the caller. Some actual safe interface is coming back at some point, currently the proof obligation is still highly reduced.
HeroicKatora
added a commit
to HeroicKatora/str-concat
that referenced
this pull request
Jul 22, 2019
See issue oberien#7, we must guarantee that slices are from the same allocation. However, pointer equality testing can not reliably test this so it must be provided by the caller. Some actual safe interface is coming back at some point, currently the proof obligation is still highly reduced.
HeroicKatora
changed the title
concat_sliceconcat_slice and mark everything as unsafe
oberien
requested changes
Feb 5, 2020
|
Could you please also add an example of |
This was referenced Feb 5, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chooses the very cautious option of erroring in all cases of a ZST
concatentation for now.