Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

89 sqrt #94

Merged
merged 5 commits into from
Nov 25, 2022
Merged

89 sqrt #94

merged 5 commits into from
Nov 25, 2022

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Nov 24, 2022 •
edited
Loading

Closes: #89, #92
Implemented number.sqrt
Tests are already exist.

@levBagryansky
Copy link
Member Author

@EugeneDar please review

EugeneDar
EugeneDar approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@EugeneDar EugeneDar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky looks good.

@yegor256 please, have a look.

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 25, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5112a27 into objectionary:master Nov 25, 2022
@rultor
Copy link
Contributor

rultor commented Nov 25, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EugeneDar EugeneDar EugeneDar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

number.sqrt object
4 participants
@levBagryansky @yegor256 @rultor @EugeneDar