-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2024-05-13 release artefacts #333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does not look correct. It should compare the draft release with the latest public release (v2024-03-27), but it does not do that:
# Ontology comparison
## Left
- Ontology IRI: `http://purl.obolibrary.org/obo/oba.owl`
- Version IRI: `http://purl.obolibrary.org/obo/oba/releases/2024-01-12/oba.owl`
- Loaded from: `file:/work/src/ontology/tmp/current-release.owl`
## Right
- Ontology IRI: `http://purl.obolibrary.org/obo/oba.owl`
- Version IRI: `http://purl.obolibrary.org/obo/oba/releases/2024-05-13/oba.owl`
- Loaded from: `file:/work/src/ontology/oba.owl`
I think the problem stems for the oba.owl
file not being under github version control any longer.
Sorry, but could you download a copy of the v2024-03-27 oba.owl file (to the root of your local bio-attribute-ontology
folder) and run the release pipeline again?
You can get the v2024-03-27 oba.owl file using these commands:
cd [location of your local bio-attribute-ontology folder]
wget https://github.com/obophenotype/bio-attribute-ontology/releases/download/v2024-03-27/oba.owl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wget
option to overwrite any existing files with the same name is -O
, in case you already had an oba.owl
file in your local file system:
wget https://github.com/obophenotype/bio-attribute-ontology/releases/download/v2024-03-27/oba.owl -O ./oba.owl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run some tests, but I do not know how to fix this so that the latest version is being compared to the draft release product. Let's ignore this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of changes (more axioms) compared with the previous release, but most of the changes are due to #314.
Otherwise I could not find any outstanding errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run some tests, but I do not know how to fix this so that the latest version is being compared to the draft release product. Let's ignore this for now.
No description provided.