Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Robot diff GH Action on PRs #3283

Merged
merged 1 commit into from
May 24, 2024
Merged

Update Robot diff GH Action on PRs #3283

merged 1 commit into from
May 24, 2024

Conversation

anitacaron
Copy link
Collaborator

@anitacaron anitacaron commented May 23, 2024

Remove alternative action to run docker on macos runner. GH increased memory on the ubuntu-latest label, so we can update the diff action to use ubuntu-latest.

This also align more closely to the same action available in CL.

  • Add branch status job before generating diff
  • Create different jobs

It's also updated to generate the classified ontology on the base, which is now the case.

Technically fixes #3183

@anitacaron anitacaron self-assigned this May 23, 2024
@anitacaron anitacaron requested review from matentzn and gouttegd May 23, 2024 16:05
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see anything glaringly wrong, but my review was a C- in terms of rigour. I think the risk is low to merge and then try.

@anitacaron anitacaron merged commit 76802af into master May 24, 2024
@anitacaron anitacaron deleted the update-actions branch June 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use official GHA docker-practice/actions-setup-docker when fix is available
2 participants