Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Version into OpAMP Client #1215

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Sep 5, 2023

Proposed Change

Modified to pass the version into the OpAMP client rather than pulling it from the version package. This way we can easily set collector version in Amplify scaling tool.

Checklist
  • Changes are tested
  • CI has passed

@cpheps cpheps requested a review from a team as a code owner September 5, 2023 14:21
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested against BindPlane.

@cpheps cpheps merged commit 7bb2826 into release/v1.34.0 Sep 6, 2023
12 checks passed
@cpheps cpheps deleted the allow-version-to-pass-opamp branch September 6, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants