-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SSAPI Exporter Integration Test (BPS-279) #2023
Conversation
Having trouble reproducing these test failures on my branch. LMK if you have any ideas @schmikei |
@@ -111,6 +111,9 @@ func (ssapir *splunksearchapireceiver) Shutdown(ctx context.Context) error { | |||
|
|||
func (ssapir *splunksearchapireceiver) runQueries(ctx context.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm missing something (which I may be. I haven't looked beyond the failing test and this function), I believe your test failures are related to this function.
It looks like the logic here is to make your query, wait for it, and then start retrieving the search results and processing them in a loop until the # of search results are less than the max possible returned in a single page. If that's the case you quit the infinite loop, otherwise you try to get another page of results.
Now what happens if it was your last page of results, but the number of results was the max number that can fit within a page (as is with the failing test)? It seems like you try to get search results but get an error because there are none.
Hopefully I'm right or at least half right and this puts you on the right track to fixing the CI issues.
Proposed Change
Add a new integration test to simulate a failure from the exporter that would travel back up the pipeline while blocking after calling
ConsumeLogs
.Checklist