fix(tracing): Set sampling rate (#128)

observIQ · May 16, 2024 · 19d9bfb · 19d9bfb
1 parent 49fa5d1
commit 19d9bfb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/charts/bindplane/Chart.yaml b/charts/bindplane/Chart.yaml
@@ -3,7 +3,7 @@ name: bindplane
 description: BindPlane OP is an observability pipeline.
 type: application
 # The chart's version
-version: 1.11.2
+version: 1.11.3
 # The BindPlane OP tagged release. If the user does not
 # set the `image.tag` values option, this version is used.
 appVersion: 1.57.0

diff --git a/charts/bindplane/README.md b/charts/bindplane/README.md
@@ -1,6 +1,6 @@
 # bindplane
 
-![Version: 1.11.2](https://img.shields.io/badge/Version-1.11.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.57.0](https://img.shields.io/badge/AppVersion-1.57.0-informational?style=flat-square)
+![Version: 1.11.3](https://img.shields.io/badge/Version-1.11.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.57.0](https://img.shields.io/badge/AppVersion-1.57.0-informational?style=flat-square)
 
 BindPlane OP is an observability pipeline.
 
@@ -152,6 +152,7 @@ BindPlane OP is an observability pipeline.
 | tolerations | object | `{}` | The Pod's tolerations |
 | trace.otlp.endpoint | string | `""` | Endpoint of the OTLP trace receiver. Should be in the form of ip:port or host:port. |
 | trace.otlp.insecure | bool | `false` | Set to `true` to disable TLS. Set to false if TLS is in use by the OTLP trace receiver. |
+| trace.otlp.samplingRate | string | `"1"` | Sampling rate between 0 and 1. 1 being 100% of traces are sent. |
 | trace.type | string | `""` | Trace type to use. Valid options include `otlp`. |
 | transform_agent.name | string | `""` | Transform Agent Image name to be used. Defaults to `ghcr.io/observiq/bindplane-transform-agent`. |
 | transform_agent.replicas | int | `1` | Number of replicas to use for the transform agent. |

diff --git a/charts/bindplane/templates/bindplane-jobs.yaml b/charts/bindplane/templates/bindplane-jobs.yaml
@@ -152,6 +152,8 @@ spec:
               value: {{ .Values.trace.otlp.endpoint }}
             - name: BINDPLANE_TRACING_OTLP_INSECURE
               value: "{{ .Values.trace.otlp.insecure }}"
+            - name: BINDPLANE_TRACING_SAMPLING_RATE
+              value: "{{ .Values.trace.otlp.samplingRate }}"
             {{- end }}
             - name: BINDPLANE_LOGGING_OUTPUT
               value: stdout

diff --git a/charts/bindplane/templates/bindplane.yaml b/charts/bindplane/templates/bindplane.yaml
@@ -167,6 +167,8 @@ spec:
               value: {{ .Values.trace.otlp.endpoint }}
             - name: BINDPLANE_TRACING_OTLP_INSECURE
               value: "{{ .Values.trace.otlp.insecure }}"
+            - name: BINDPLANE_TRACING_SAMPLING_RATE
+              value: "{{ .Values.trace.otlp.samplingRate }}"
             {{- end }}
             - name: BINDPLANE_LOGGING_OUTPUT
               value: stdout

diff --git a/charts/bindplane/values.yaml b/charts/bindplane/values.yaml
@@ -391,6 +391,8 @@ trace:
     endpoint: ""
     # -- Set to `true` to disable TLS. Set to false if TLS is in use by the OTLP trace receiver.
     insecure: false
+    # -- Sampling rate between 0 and 1. 1 being 100% of traces are sent.
+    samplingRate: "1"
 
 # -- Number of replicas to use for the BindPlane server. Should not be set if `autoscaling.enable` is set to `true`. 0 means this option will not be set.
 replicas: 0